doc(store): remove outdated instruction for aurelia-cli - #409
Merged
Conversation
Member
Author
|
@EisenbergEffect @zewa666 while reading aurelia-store doc, I noticed the missing Since aurelia-store is an official offering from Aurelia, I think aurelia-polyfills should cover that polyfill to smooth user experience. In fact, that polyfill is tiny, about 10 lines. Let me know what you think, I can follow up with PRs to aurelia-polyfills and store documentation. |
Contributor
Member
|
@EisenbergEffect here is the related PR for the polyfill with some discussion. aurelia/polyfills#64 I've talked to @3cp and we'd favour to get it in |
Member
|
PR looks good, the compat approach is no longer needed. Thanks @3cp for the fix. @EisenbergEffect ready for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zewa666 can you have a look? I remove the mention of rxjs-compat because the rxjs migration guide covered that, but I have no idea how to use rxjs-compat even after reading the migration guide.
The guide mentioned
npm install rxjs@6 rxjs-compat@6 --savebut has no code toimport 'rxjs-compat';. How does it work?